Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3701] NFC fixes #3264

Merged
merged 9 commits into from
Dec 5, 2023
Merged

[FL-3701] NFC fixes #3264

merged 9 commits into from
Dec 5, 2023

Conversation

gornekich
Copy link
Member

@gornekich gornekich commented Dec 5, 2023 •
edited by skotopes
Loading

What's new

  • Fix navigation after loading broken file
  • Change Iso14443-3b poller activation logic
  • Fix "Lost tag" view appearance after dict attack
  • Fix Mf Ultralight crash after entering password manually from extra actions
  • Fix Mf keys scene if there is no User dictionary
  • Fix multiple protocol tag notification.
  • Clean up aime parser

Verification

  • All fixes work correctly

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023 •
edited
Loading

Compiled f7 firmware for commit 1de12a98:

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

PVS-Studio report for commit 2dc6bb14:

@gornekich gornekich marked this pull request as draft December 5, 2023 11:25
@gornekich gornekich marked this pull request as ready for review December 5, 2023 13:09
@skotopes skotopes merged commit 82baf1e into dev Dec 5, 2023
9 checks passed
@skotopes skotopes deleted the gornek/3701_nfc_fixes branch December 5, 2023 13:40
This was referenced Dec 5, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra Astrrra is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gornekich @skotopes