Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MyKey parser #3262

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Conversation

augustozanellato
Copy link
Contributor

@augustozanellato augustozanellato commented Dec 4, 2023

What's new

Added MyKey parser. MyKeys are a kind of cashless support used on vending machines that are very common in Italy. The parser was implemented without any reverse engineered cryptography (in contrast with the implementations used by other flipper firmwares), all the displayed infos are either stored plaintext on the tag or scrambled (the only usage of scrambled data is startingOffset at line 76), this choice was made in order to prevent angry lawyers :D

Verification

  • Scan a MyKey (if you need a couple dumps feel free to DM me on Discord :) )
  • Check the parsed data correctness

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@gornekich gornekich self-assigned this Dec 5, 2023
@gornekich gornekich added the NFC NFC-related label Dec 5, 2023
@hedger
Copy link
Member

hedger commented Dec 12, 2023

@augustozanellato could you also provide sample card dumps to test that code, please?

@augustozanellato
Copy link
Contributor Author

@augustozanellato could you also provide sample card dumps to test that code, please?

@gornekich already has them, feel free to send me a dm on discord if you also want some samples :)

Copy link
Member

@gornekich gornekich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@skotopes skotopes merged commit 78b7310 into flipperdevices:dev Dec 14, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NFC NFC-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants