Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FuriHal: various GPIO improvements #3260

Merged
merged 4 commits into from
Dec 12, 2023
Merged

FuriHal: various GPIO improvements #3260

merged 4 commits into from
Dec 12, 2023

Conversation

skotopes
Copy link
Member

@skotopes skotopes commented Dec 4, 2023 •
edited
Loading

What's new

  • FuriHal: add alternative gpio pulls that covers special cases, extra checks and crash on inalid parameters.

Verification

  • GPIO analog mode now supports pull-up/pull-down
  • Check everything that uses GPIO
  • Full set of test

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023 •
edited
Loading

Compiled f7 firmware for commit d5a72ead:

hedger
hedger previously approved these changes Dec 12, 2023
View reviewed changes
@skotopes skotopes added NFC NFC-related Bug and removed NFC NFC-related Bug labels Dec 12, 2023
hedger
hedger previously approved these changes Dec 12, 2023
View reviewed changes
@hedger hedger added the Core+Services HAL, furi & core system services label Dec 12, 2023
@skotopes skotopes merged commit e2e3663 into dev Dec 12, 2023
9 checks passed
@skotopes skotopes deleted the aku/gpio_pwr_pupd branch December 12, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedger hedger hedger approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

Assignees
No one assigned
Labels
Core+Services HAL, furi & core system services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skotopes @hedger