Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FuriHal: UART refactoring #3211

Merged
merged 17 commits into from
Jan 15, 2024
Merged

FuriHal: UART refactoring #3211

merged 17 commits into from
Jan 15, 2024

Conversation

skotopes
Copy link
Member

@skotopes skotopes commented Nov 12, 2023 •
edited by hedger
Loading

What's new

  • FuriHal: UART refactoring

Verification

  • Full set of tests

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2023 •
edited
Loading

Compiled f7 firmware for commit d9aa2655:

@hedger hedger added the Core+Services HAL, furi & core system services label Nov 12, 2023
hedger
hedger reviewed Nov 14, 2023
View reviewed changes
furi/core/log.h Outdated Show resolved Hide resolved
hedger
hedger reviewed Nov 14, 2023
View reviewed changes
furi/core/log.h Outdated Show resolved Hide resolved
hedger
hedger reviewed Nov 14, 2023
View reviewed changes
targets/f18/api_symbols.csv Outdated Show resolved Hide resolved
hedger
hedger reviewed Nov 14, 2023
View reviewed changes
targets/f7/api_symbols.csv Outdated Show resolved Hide resolved
hedger
hedger reviewed Nov 14, 2023
View reviewed changes
furi/core/log.h Outdated Show resolved Hide resolved
hedger
hedger reviewed Nov 14, 2023
View reviewed changes
furi/core/log.h Outdated Show resolved Hide resolved
@hedger hedger merged commit fc043da into dev Jan 15, 2024
9 checks passed
@hedger hedger deleted the aku/uart branch January 15, 2024 23:09
@skotopes
Copy link
Member Author

Porting to new API example: skotopes/flipperzero_mhz19_uart@9612b6f

RogueMaster pushed a commit to RogueMaster/flipperzero-firmware-wPlugins that referenced this pull request Feb 13, 2024
@xMasterX @skotopes
@hedger @Skorpionm
FuriHal: UART refactoring (flipperdevices#3211)
a1e62c3 
* FuriHal: UART refactoring
* ApiSymbols: add furi_record_destroy
* FuriHal: cleanup serial API, add logging configuration in RTC
* FuriHal: hide private part in _i header. Toolbox: cleanup value index. SystemSettings: logging device and baudrate.
* FuriHal: RTC logging method documentation
* Synchronize API Symbols
* Furi: mark HEAP_PRINT_DEBUG as broken
* FuriHal: furi_hal_serial, add custom IRQ func
* Fix PR review issues
* FuriHal: UART add reception DMA (flipperdevices#3220)
* FuriHal: add DMA serial rx mode
* usb_uart_bridge: switch to working with DMA
* Sync api symbol versions
* FuriHal: update serial docs and api
* FuriHal: Selial added similar API for simple reception mode as with DMA
* FuriHal: Update API target H18
* API: ver API H7
* FuriHal: Serial error processing
* FuriHal: fix furi_hal_serial set baudrate
* Sync api symbols
* FuriHal: cleanup serial isr and various flag handling procedures
* FuriHal: cleanup and simplify serial API
* Debug: update UART Echo serial related flags
* FuriHal: update serial API symbols naming
* FuriHalSerial: various improvements and PR review fixes
* FuriHal: proper ISR function signatures

---------

Co-authored-by: Aleksandr Kutuzov <[email protected]>
Co-authored-by: hedger <[email protected]>
Co-authored-by: SkorP <[email protected]>
Co-authored-by: Skorpionm <[email protected]>
@andreww24
Copy link

Hello! It is possible to add ext function for uart initialization?
With additional parameters, like parity, number stop bit, inverse level of channels( RXINV and TXINV)?
Inverse level is frequently needed for some 1-wire uart physical impementation.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luminus82 luminus82 luminus82 left review comments

@hedger hedger hedger approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@drunkbatya drunkbatya Awaiting requested review from drunkbatya

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

Assignees
No one assigned
Labels
Core+Services HAL, furi & core system services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@skotopes @0xchocolate @Tetr0N @andreww24 @hedger @luminus82 @Skorpionm