Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] MF Ultralight no pwd polling adjustment #3207

Merged
merged 5 commits into from
Nov 15, 2023
Merged

[NFC] MF Ultralight no pwd polling adjustment #3207

merged 5 commits into from
Nov 15, 2023

Conversation

RebornedBrain
Copy link
Contributor

@RebornedBrain RebornedBrain commented Nov 8, 2023 •
edited by gornekich
Loading

What's new

Now if no password got during polling, device will show that not all pages were read

Verification

On any NTAG:

  • Set some AUTHLIM value.
  • Set AUTH0 = 0xFF to disable read auth function.
  • Set some not default password to card
  • Try to read any NTAG with not default PWD.

Result: On read success screen Pages read will be less than total by 2 pages and "Password-protected pages!" string will be present

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

gornekich
gornekich previously approved these changes Nov 8, 2023
View reviewed changes
@hedger hedger added the NFC NFC-related label Nov 8, 2023
@skotopes skotopes merged commit d0b9a3a into flipperdevices:dev Nov 15, 2023
9 checks passed
@gornekich gornekich mentioned this pull request Nov 15, 2023
Closed
@RebornedBrain RebornedBrain deleted the reborned/ntag215_fixes branch August 19, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gornekich gornekich gornekich approved these changes

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra Astrrra is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@Skorpionm Skorpionm Awaiting requested review from Skorpionm Skorpionm is a code owner

Assignees
No one assigned
Labels
NFC NFC-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RebornedBrain @skotopes @gornekich @hedger