Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3657] Fix NFC unit tests #3192

Merged
merged 2 commits into from
Nov 9, 2023
Merged

[FL-3657] Fix NFC unit tests #3192

merged 2 commits into from
Nov 9, 2023

Conversation

gornekich
Copy link
Member

@gornekich gornekich commented Nov 2, 2023 •
edited by skotopes
Loading

What's new

  • Change 4th uid byte setting rule as 0x88 value is forbidden for new uid cascade and breaks iso14443-3a poller

Verification

  • NFC unit tests work all the time

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023 •
edited
Loading

Compiled f7 firmware for commit 933f0f3e:

@hedger hedger added the NFC NFC-related label Nov 8, 2023
@skotopes skotopes merged commit 16ffa2b into dev Nov 9, 2023
9 checks passed
@skotopes skotopes deleted the gornek/3657_nfc_fix_unit_tests branch November 9, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra Astrrra is a code owner

Assignees
No one assigned
Labels
NFC NFC-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gornekich @skotopes @hedger