Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fbt: source collection improvements #3181

Merged
merged 5 commits into from
Nov 1, 2023
Merged

fbt: source collection improvements #3181

merged 5 commits into from
Nov 1, 2023

Conversation

hedger
Copy link
Member

@hedger hedger commented Oct 31, 2023 •
edited by skotopes
Loading

What's new

  • fbt: added source exclusion pattern support for sources field in application manifests
  • apps: fixed excessive globbing of sources for apps, resulting in extra .o files
  • Paths starting with "!" are excluded from the list of sources. They can also include wildcard characters and directory names. For example, a value of ["*.c*", "!plugins"] will include all C and C++ source files in the app folder except those in the plugins (and lib) folders.

Verification

  • Compare build time with dev, check out pvs run logs

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 31, 2023 •
edited
Loading

Compiled f7 firmware for commit b982d28e:

@hedger hedger marked this pull request as ready for review October 31, 2023 22:00
@hedger hedger added the Build System & Scripts fbt, scripts and toolchain-related label Oct 31, 2023
@skotopes skotopes merged commit 7bd3bd7 into dev Nov 1, 2023
9 checks passed
@skotopes skotopes deleted the hedger/fbt_glob_v2 branch November 1, 2023 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@drunkbatya drunkbatya Awaiting requested review from drunkbatya

@Skorpionm Skorpionm Awaiting requested review from Skorpionm Skorpionm is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra Astrrra is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

Assignees
No one assigned
Labels
Build System & Scripts fbt, scripts and toolchain-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hedger @skotopes