NFC: Improved MFC emulation on some readers #2825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AloneLiberty
force-pushed
the
nfc-mfc-emulation-fix
branch
from
662b2f2 to
a198981
Compare
Some Android devices don't like this
I knew that during the emulation timings are critical, but one log breaks all...
Add fixes to Detect reader and refactor code
GUI doesn't update without delay
AloneLiberty
requested review from
skotopes,
DrZlo13,
hedger,
gornekich and
Astrrra
as code owners
gornekich
requested changes
Jul 11, 2023
There was a problem hiding this comment.
Hello @AloneLiberty ! Thanks for PR. Tested it and it works good.
Please, make some changes I mentioned and we will merge your PR
Reworked emulation flow, some bug fixes and improvements
…irmware into nfc-mfc-emulation-fix
…ty/flipperzero-firmware into nfc-mfc-emulation-fix
skotopes
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
HALT don't disable field (because in the real world the card cannot turn itself off)
Fixes for faster re-select of card (because we know that in these cases the reader will read again)
Removed not particularly necessary warning output, in general improves the emulation (
hf mf fchk, Android with different keys)Add trace log if reader send RATS
Added check if the block is read, if not, it won't access it (won't reply zeros)
Added check if we access a block we're authorized (don't allow access outside current sector)
Verification
nfc-mfclassic r a u dumpon ACR122U should work nowEmulation should work on more Android devices (at least now works on mine)
hf mf chk,hf mf fchkand evenhf mf hardnestedproxmark3 commands works stableTest for regression on other readers
Checklist (For Reviewer)