-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File Browser: Enable 5 Step Scrolling #2730
Conversation
Just do |
Done!Thankyou, I can squash to 1 commit if you want. |
Hey @hedger, there is not compiled firmware from github-actions here?? |
@asizon compiled but not uploaded to update server |
We'll discuss this PR with UI/UX team and come back later with more info. Meanwhile I'll postpone this PR to next release. |
@skotopes It seems like a good solution, but not good enough to provide the user with comfort and fluidity in moving between files in the file browser. If you look at the UI of many systems you will see that they combine the two scroll options, accelerated scrolling and also more precise scrolling of 5 by 5 (even 10 by 10) which makes it easier and provides more comfort. It is also true that when enabling this new mode we should notify the user that this scrolling is active in some way (scroll bar dimensions change for example). |
What's new
A new function is added to help moving between files in the file browser, when there are many files the only way up to now to make large movements is by keeping the keyup or keydown pressed. This PR helps to scroll in a more comfortable way by activating the scroll of 5 by 5 when pressing the right key.
Verification
Enter filebrowser for example through the infrared option, with an extensive database loaded. Press right key to activate 5-step scroll and scroll up or down. Press the left key to deactivate the 5-step scrolling, once deactivated, the left key returns to have the function of going to root if it is not there yet.
Checklist (For Reviewer)