[DRAFT/WIP] added ISO15693 reading, saving and revealing from privacy mode (unlock) #1991

g3gg0 · 2022-11-09T13:21:03Z

What's new

Added NfcV through various layers
Added NfcV memory and system info reading
Added loading/saving
Added unlocking NfcV NXP SLIX-L (reveal from privacy mode)

Purpose

This is a draft / WIP, being aware that:

Scenes are not clean or thought-through well I guess
rfalNfcv* calls are being made from lib/ level
big API change pending

Just to show whats happening.

Astrrra · 2022-11-09T13:22:01Z

Hi, please convert the PR to a draft via Github tools, as it's currently in the "Open" state

g3gg0 · 2022-11-09T13:24:54Z

ah, great. didn't know that. done :)

g3gg0 · 2022-11-09T14:41:38Z

As already discussed in Telegram the file format code might need some updates.
This can be done without any effect on existing files, however the code might need some update in future.

Of couse we can implement it "flat" with just a single enum, but on the long run this might end in a mess.

Here a visualization of how "hierarchical" it is/will get:

changed save format to reflect this executing emulation from browser now also works

fixed byte order mixup read larger cards

updated API file

updated nfcv to use pulse_reader instead of bitbanging

added yielding to emulation loop

updated DigitalSequence API

…der' into g3gg0/ISO15693

Enteee · 2022-12-25T09:29:08Z

This pull request would be a great addition, I have tested this briefly with several cards. Reading seems to work fine, but I could not get the emulation to work properly. Namely, the emulated cards were not accepted by any devices I tested them with. Sadly I don't have the hardware required to debug this further.

g3gg0 · 2022-12-25T13:13:39Z

@Enteee
Yeah this is likely if the reader uses AM instead of OOK.
The ST should support AM in transparent mode, it's just not documented.
The chip is said to modulate the IRQ line instead of MISO, but for some reason that doesnt work.
Maybe some register settings, we'll see.

Currently investigating this with a guy who wants to emulate picopas. Thats also the reason why i reworked the code a bit lately.

Also see:
https://community.st.com/s/question/0D73W000001oEvPSAU/detail

ZAM- · 2023-01-12T22:27:21Z

Tested the ISO15693 emulation with Ikon ski pass and it worked! Any idea if/when writing would be implemented? @g3gg0

g3gg0 · 2023-01-12T22:29:36Z

hi, great to hear that.
what do you want to write where?
just copy content to another card?

the UID of a card is not changeable btw.

ZAM- · 2023-01-12T22:34:36Z

@g3gg0 Yes I would just like to copy to another card without changing UID.

g3gg0 · 2023-01-12T23:04:59Z

i see.
currently i didn't plan this, but good point.

team-orangeBlue · 2023-01-15T18:05:13Z

you ask the reliability (current reliability: 0%) of rogue master to rogue master

or be a good boy and dont get close to it

pcunning · 2023-01-15T20:33:55Z

This pull request is not the place for Q&A or help. If you would like to discuss other firmware go discuss it on their GitHub. Please keep discussion to code and implementation of the given PR.

Additionally if you are using the functionality of this PR in another firmware there is probably a reason it is not merged here yet and they were premature in merging it into their codebase.

alvarotorijano · 2023-01-16T10:37:28Z

Hi, nice work! I have been waiting for this feature since some time ago. I would like to mention that this type of cards are not listed in the "extra actions -> read specific card type" inside the NFC main app. Would be great to add it to this menu!

neich03 · 2023-01-17T16:32:32Z

community gives thanks for your great job! NFC-V is so important! i can´t believe F0 team didn´t work more on it... every step forward is hugely appreciated!. thanks!

bettse · 2023-01-17T16:45:04Z

@neich03

NFC-V is so important! i can´t believe F0 team didn´t work more on it

Firstly, this is not related to the PR and development, which as mentioned, should be avoided. Secondly, your phrasing can be seen as diminishing the Flipper Zero team when they are very very hard at work and have to prioritize the various subsystems the flipper zero has. Stick to statements of excitement and avoid statements that can be seen as critical.

If you would delete your comment to clean up the PR, I will follow by deleting this reply.

g3gg0 · 2023-01-17T17:00:46Z

@neich03

NFC-V is so important! i can´t believe F0 team didn´t work more on it

Firstly, this is not related to the PR and development, which as mentioned, should be avoided. Secondly, your phrasing can be seen as diminishing the Flipper Zero team when they are very very hard at work and have to prioritize the various subsystems the flipper zero has. Stick to statements of excitement and avoid statements that can be seen as critical.

If you would delete your comment to clean up the PR, I will follow by deleting this reply.

while i agree that this is not for unrelated discussion, i do not get why this comment should be critical.
noone was insulted and this comment wasnt unreasonably unfriendly.

just explain to him that
"NfcV is not that widespread and they focused other things first and he should't worry."
and "things will take its time and good developers can't work faster even with more money."

forbidding that kind of questioning is something i dont expect from open source projects.

topic:
draft-PR closed, will create another one from another branch

neich03 · 2023-01-17T17:11:51Z

@neich03

NFC-V is so important! i can´t believe F0 team didn´t work more on it

Firstly, this is not related to the PR and development, which as mentioned, should be avoided. Secondly, your phrasing can be seen as diminishing the Flipper Zero team when they are very very hard at work and have to prioritize the various subsystems the flipper zero has. Stick to statements of excitement and avoid statements that can be seen as critical.

If you would delete your comment to clean up the PR, I will follow by deleting this reply.

just wanted to give thanks to those who work for NFC-V working in the future. And love for F0 team as well. just wondering why something with so many applications is not tagged as priority. but of course, not my business. just thanks to all!

skotopes · 2023-01-17T17:14:18Z

NFC Hal is currently being rewritten, we'd like to finalize low level before switching to "V". Also team is currently on vacation we'll resume normal merge flow in next couple days.

ImSwifted · 2023-03-02T12:27:02Z

Top

alvarotorijano · 2023-03-02T16:24:59Z

Highly apreciated. Would be great to be able to write data to the card, editing dump, writing dumped data, etc

MadjidZ · 2023-05-07T14:06:01Z

Hello @g3gg0

I tested this branch on my FZ.

Read and emulate NFCV are ok but the reader does not react by offering him the emulator card from the FZ.

I therefore wonder about the emulation which seems incorrect. I have to try to copy the FZ card to a real SLI/SLIX UID card that can be found here:
https://lab401.com/fr/products/icode-sli-slix-compatible-uid-modifiable?_pos=10&_sid=0a2e4b59f&_ss=r

If you want to take a look at the copy of the NFC-V card (copy-nfc-v-iso15963.nfc) with which I tested it is available here: https://file.io/AeR1zNkIFpis

Thank you for advancing the reading of NFC-V

g3gg0 · 2023-05-07T16:34:44Z

also: did you use this stale, old branch or the PR?

MadjidZ · 2023-05-07T17:36:51Z

Sorry for expired link, i upload another here : https://easyupload.io/z7eqgt

I test branch "ISO15693" of https://github.com/g3gg0/flipperzero-firmware.git

I got the source via git, then built the dfu via fbt

g3gg0 · 2023-05-07T18:06:49Z

I don't get it, why do you comment on a totally different branch?

go and test this one: #2316

added ISO15693 reading, saving and revealing from privacy mode (unlock)

c840e9a

g3gg0 requested review from skotopes, DrZlo13, hedger, gornekich and Astrrra as code owners November 9, 2022 13:21

g3gg0 marked this pull request as draft November 9, 2022 13:24

g3gg0 added 20 commits November 9, 2022 21:19

fix naming ReadAuth->Unlock

fa74fc9

rename file to match scene name

8d2daa7

implemented unlock, read, save sequence

fe216b4

added NfcV emulation

bcd33ca

separate ISO15693 basic and SLIX extensions a bit more

75f5e66

changed save format to reflect this executing emulation from browser now also works

always save file even when tag was not locked

b480224

cleaned up SLIX code

971e009

fixed byte order mixup read larger cards

some more comments

d6903a4

updated API file

temporary DMA based timer capturing

24f8db3

added pulse_reader for DMA based NFC signal reading

01137a5

updated nfcv to use pulse_reader instead of bitbanging

log code updates, showing the last entries only

08a5fee

fix log truncation

1344f8f

switch to scalable timebase for digital reader to prevent overflows

f2457b6

added yielding to emulation loop

switch to signal sequence (nonfunc)

820ccb9

fix an off-by-one error

f0feb89

switch to DigitalSequence

cd241a2

smaller code cleanups

aad093a

switch NfcA to digital sequence also

a1ae1ed

updated DigitalSequence API

fix NfcA

8b4e6de

clean up digital_signal.c and fix remainder calculation

fe9bc3e

g3gg0 added 8 commits December 21, 2022 01:01

fix starting level detection in pulse_reader

70faa47

added unit test for pulse_reader

868e8a0

Merge branch 'dev' into DigitalSequence_PulseReader

126c584

change pulse reader test timings to 1, 10 and 100 ms

42bb1aa

fine tuned timings for pulse_reader test

c641960

Merge remote-tracking branch 'remotes/origin/DigitalSequence_PulseRea…

10e396d

…der' into g3gg0/ISO15693

fixed formatting of NfcV code

f910f1a

updated subprojects and merge issues

9babb32

g3gg0 closed this Jan 17, 2023

g3gg0 mentioned this pull request Jan 17, 2023

added ISO15693 (NfcV) reading, saving, emulating and revealing from privacy mode (unlock) #2316

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DRAFT/WIP] added ISO15693 reading, saving and revealing from privacy mode (unlock) #1991

[DRAFT/WIP] added ISO15693 reading, saving and revealing from privacy mode (unlock) #1991

g3gg0 commented Nov 9, 2022

Astrrra commented Nov 9, 2022

g3gg0 commented Nov 9, 2022

g3gg0 commented Nov 9, 2022 •

edited

Loading

Enteee commented Dec 25, 2022

g3gg0 commented Dec 25, 2022 •

edited

Loading

ZAM- commented Jan 12, 2023

g3gg0 commented Jan 12, 2023

ZAM- commented Jan 12, 2023

g3gg0 commented Jan 12, 2023

team-orangeBlue commented Jan 15, 2023 •

edited

Loading

pcunning commented Jan 15, 2023 •

edited

Loading

alvarotorijano commented Jan 16, 2023

neich03 commented Jan 17, 2023

bettse commented Jan 17, 2023

g3gg0 commented Jan 17, 2023 •

edited

Loading

neich03 commented Jan 17, 2023

skotopes commented Jan 17, 2023

ImSwifted commented Mar 2, 2023

alvarotorijano commented Mar 2, 2023

MadjidZ commented May 7, 2023

g3gg0 commented May 7, 2023

MadjidZ commented May 7, 2023 •

edited

Loading

g3gg0 commented May 7, 2023 •

edited

Loading

[DRAFT/WIP] added ISO15693 reading, saving and revealing from privacy mode (unlock) #1991

[DRAFT/WIP] added ISO15693 reading, saving and revealing from privacy mode (unlock) #1991

Conversation

g3gg0 commented Nov 9, 2022

What's new

Purpose

Astrrra commented Nov 9, 2022

g3gg0 commented Nov 9, 2022

g3gg0 commented Nov 9, 2022 • edited Loading

Enteee commented Dec 25, 2022

g3gg0 commented Dec 25, 2022 • edited Loading

ZAM- commented Jan 12, 2023

g3gg0 commented Jan 12, 2023

ZAM- commented Jan 12, 2023

g3gg0 commented Jan 12, 2023

team-orangeBlue commented Jan 15, 2023 • edited Loading

pcunning commented Jan 15, 2023 • edited Loading

alvarotorijano commented Jan 16, 2023

neich03 commented Jan 17, 2023

bettse commented Jan 17, 2023

g3gg0 commented Jan 17, 2023 • edited Loading

neich03 commented Jan 17, 2023

skotopes commented Jan 17, 2023

ImSwifted commented Mar 2, 2023

alvarotorijano commented Mar 2, 2023

MadjidZ commented May 7, 2023

g3gg0 commented May 7, 2023

MadjidZ commented May 7, 2023 • edited Loading

g3gg0 commented May 7, 2023 • edited Loading

g3gg0 commented Nov 9, 2022 •

edited

Loading

g3gg0 commented Dec 25, 2022 •

edited

Loading

team-orangeBlue commented Jan 15, 2023 •

edited

Loading

pcunning commented Jan 15, 2023 •

edited

Loading

g3gg0 commented Jan 17, 2023 •

edited

Loading

MadjidZ commented May 7, 2023 •

edited

Loading

g3gg0 commented May 7, 2023 •

edited

Loading