-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SD info: Add dynamic units and free % #1634
Conversation
@@ -24,13 +24,44 @@ void storage_settings_scene_sd_info_on_enter(void* context) { | |||
dialog_ex, "Try to reinsert\nor format SD\ncard.", 3, 19, AlignLeft, AlignTop); | |||
dialog_ex_set_center_button_text(dialog_ex, "Ok"); | |||
} else { | |||
char unit_kb[] = "KB"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to put it in ram, use const.
char unit_mb[] = "MB"; | ||
char unit_gb[] = "GB"; | ||
|
||
double sd_total_val = (double)sd_info.kb_total; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using float point math here is kinda overkill.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Especially using double. Float should be more than enough, use cast at the last moment when passing it to string_printf.
double sd_free_val = (double)sd_info.kb_free; | ||
char* sd_free_unit = unit_kb; | ||
|
||
if(sd_total_val > 1024) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better solution will be to implement formatting function that takes double* and const char**
@non-bin do you plan to continue work on this PR? |
Yeah I will |
Feel free to reopen when it will be ready |
What's new
Verification
Checklist (For Reviewer)