New frequency analyzer #1501
New frequency analyzer #1501
Conversation
ClusterM
requested review from
skotopes,
DrZlo13,
hedger and
Skorpionm
as code owners
Astrrra
added
Sub-GHz
|
I have formatted the code. |
|
One last minor fix: round frequency value to KHz (299999990Hz to 300000000Hz). |
| @@ -20,11 +37,20 @@ struct SubGhzFrequencyAnalyzer { | |||
| SubGhzFrequencyAnalyzerCallback callback; | |||
| void* context; | |||
| bool locked; | |||
| float rssi_last; | |||
| uint32_t frequency_last; | |||
There was a problem hiding this comment.
I think this does not solve the underlying issue.
If one is scanning a busy area, the "last" would flicker just as much as the "current", making it unreadable the same way as the existing implementation.
#opinionated
There was a problem hiding this comment.
I think this does not solve the underlying issue.
If one is scanning a busy area, the "last" would flicker just as much as the "current", making it unreadable the same way as the existing implementation.
#opinionated
No, it's updated with the last value after there is no signal for a while.
There was a problem hiding this comment.
Ah. I see. Well, the last time I used c was about 15 years ago 😅
Anyhow, it would be great to reuse the subghz_history and utilize the up and down arrows to navigate in the history. What do you think?
I have been trying to do just that, but unfortunately c was really really a long time ago.. 😞
There was a problem hiding this comment.
Anyhow, it would be great to reuse the
subghz_historyand utilize the up and down arrows to navigate in the history. What do you think?
I think that it's good idea but i'm not ready to implement it now. Maybe later.
There was a problem hiding this comment.
Hello,
What's the best way to contribute to the "history feature" ?
Waiting for this PR to be validated ? Forking your fork & PR to it ?
There was a problem hiding this comment.
Hello,
What's the best way to contribute to the "history feature" ? Waiting for this PR to be validated ? Forking your fork & PR to it ?
Not sure. Let's wait for PR to be validated.
There was a problem hiding this comment.
Damn I wish I was better at cpp! 😅
This comment was marked as abuse.
This comment was marked as abuse.
|
I just don't want to wait. So I closed it and merged it into 3rd party branch. GitHub can't fork two projects with the same name. |
This comment was marked as abuse.
This comment was marked as abuse.
|
Created new pull request: #1557 |
What's new
New frequency analyzer view:
Verification
Checklist (For Reviewer)