Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Luau analysis to CI #94

Merged
merged 17 commits into from
May 28, 2022
Merged

Add Luau analysis to CI #94

merged 17 commits into from
May 28, 2022

Conversation

vocksel
Copy link
Collaborator

@vocksel vocksel commented Apr 30, 2022

Trying to setup the awesome luau-analyze-rojo so we can get type analysis in CI

Closes #89

Checklist

@vocksel
Copy link
Collaborator Author

vocksel commented May 27, 2022

Despite analysis failing, the only failure is to do with Roact which it does not seem we can override because it explicitly includes --nonstrict in the header and .luaurc can't override that.

So, I'm calling this good! We now have Luau analysis for flipbook

@vocksel vocksel requested a review from passhley May 27, 2022 17:33
@vocksel vocksel marked this pull request as ready for review May 27, 2022 17:33
@vocksel vocksel merged commit aff1130 into main May 28, 2022
@vocksel vocksel deleted the luau-analysis branch May 28, 2022 02:16
Copy link
Collaborator

@passhley passhley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup Luau analysis with luau-analyze-rojo
2 participants