add compose_mod and powmod with large exp #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiacomoPope
force-pushed
the
improve_powmod_and_compose
branch
from
075e9e3
to
99b91fb
Compare
| cdef nmod_poly res | ||
|
|
||
| if e < 0: | ||
| raise ValueError("Exponent must be non-negative") |
There was a problem hiding this comment.
Would it make sense to use inverse_mod here?
Or maybe the caller should just do that if needed.
There was a problem hiding this comment.
Yeah good question. I don't think we invert where e is negative elsewhere, but this is a reasonable thing to do.
There was a problem hiding this comment.
Inverting does bring additional complications though because I think then we need the modulus to be irreducible.
GiacomoPope
force-pushed
the
improve_powmod_and_compose
branch
from
a2f80ba
to
4495a4c
Compare
GiacomoPope
force-pushed
the
improve_powmod_and_compose
branch
from
4495a4c
to
e0312f8
Compare
|
Hopefully addressed the above comments |
|
Yep, looks good. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds two features which i need for a current project:
I'm a little rusty as I haven't thought about flint for a while, and there's one TODO for the
__pow__test as now fmpz_mod_poly does not raise an assertion error when a modulus is given generically