Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kaios] Fix default target #1817

Merged
merged 2 commits into from
Dec 10, 2024
Merged

[kaios] Fix default target #1817

merged 2 commits into from
Dec 10, 2024

Conversation

Marius456
Copy link
Contributor

Description

  • Add functionality to update default target for KaiOS

Related issues

Npm releases

n/a

@Marius456 Marius456 added the e2e label Dec 4, 2024
@Marius456 Marius456 added this to the 1.9 milestone Dec 4, 2024
@Marius456 Marius456 self-assigned this Dec 4, 2024
@Marius456 Marius456 marked this pull request as ready for review December 5, 2024 07:12
@Marius456 Marius456 added e2e and removed e2e labels Dec 5, 2024
pauliusguzas
pauliusguzas requested changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@pauliusguzas pauliusguzas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The defaultTarget itself seems to be working, but kaios simulator is being looked for at weird path
image

And also weird target is being added to renative.json (last one)
image

Full renative.json below
XsKueFY4

@Marius456
Copy link
Contributor Author

KAIOS_SDK should be only until Downloads folder: /home/testlab-ubuntu/Downloads

From kaios simulator side the problem is that by unzipping differently you get 2 unique folders. So it should be kaiosrt.v2.5-us-US.linux-x86_64 in Downloads folder.

@pauliusguzas pauliusguzas self-requested a review December 8, 2024 20:45
@locksten locksten self-requested a review December 9, 2024 08:03
@Marius456 Marius456 merged commit 0f9d90d into main Dec 10, 2024
13 checks passed
@Marius456 Marius456 deleted the fix/kaios_default_target branch December 10, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauliusguzas pauliusguzas pauliusguzas approved these changes

@locksten locksten locksten approved these changes

Assignees

@Marius456 Marius456

Labels
e2e
Projects
None yet
Milestone
1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@Marius456 @locksten @pauliusguzas