-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tizen devices fixes #1703
Tizen devices fixes #1703
Conversation
@justinasRm could you write down impacted commands, what is expected of them? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npx rnv run -p tizen -t
npx rnv run -p tizen
(when no default target added to renative.json)
shows this question (expected: choose from all targets - sims and devices)
? Could not find or connect to the specified target (undefined). Would you like
to start an emulator?
Also seems like npx rnv target launch -p tizen
tries to install app? for me TV get's stuck on "RNVanillaTV Loading" spinner, no controls on tv work. I am not sure what this command should to with devices, but definetely not install app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
? What emulator would you like to launch?
as this asks from emulators and devices, this question should be changed
also github actions task is failing
also target launch when using -t flag still displays real device
pauliusguzas@MBP-de-Flexn template-starter % npx rnv target launch -p tizen
┌─────────────────────────────────────────────────────────────────┐
│ ██████╗ ███████╗███╗ ██╗ █████╗ ████████╗██╗██╗ ██╗███████╗ │
│ ██╔══██╗██╔════╝████╗ ██║██╔══██╗╚══██╔══╝██║██║ ██║██╔════╝ │
│ ██████╔╝█████╗ ██╔██╗ ██║███████║ ██║ ██║██║ ██║█████╗ │
│ ██╔══██╗██╔══╝ ██║╚██╗██║██╔══██║ ██║ ██║╚██╗ ██╔╝██╔══╝ │
│ ██║ ██║███████╗██║ ╚████║██║ ██║ ██║ ██║ ╚████╔╝ ███████╗ │
│ ╚═╝ ╚═╝╚══════╝╚═╝ ╚═══╝╚═╝ ╚═╝ ╚═╝ ╚═╝ ╚═══╝ ╚══════╝ │
│ 🚀 v:1.2.0-rc.1 | renative.org | 9/18/2024, 5:28:07 PM │
│ $ rnv target launch -p tizen │
└─────────────────────────────────────────────────────────────────┘
info: Current engine: @rnv/engine-rn-web (../engine-rn-web)
task: ○ target launch ↺1
task: ○ workspace configure ↺1
task: ✔ workspace configure
? Which target to use? Pick from available targets...
✔ Executing: "/Users/pauliusguzas/tizen-studio/tools/emulator/bin/em-cli" list-vm
✔ Executing: "/Users/pauliusguzas/tizen-studio/tools/sdb" devices
✔ Executing: "/Users/pauliusguzas/tizen-studio/tools/emulator/bin/em-cli" detail -n T-8.0-x86_64
✔ Executing: "/Users/pauliusguzas/tizen-studio/tools/emulator/bin/em-cli" detail -n T-samsung-7.0-x86
✔ Executing: "/Users/pauliusguzas/tizen-studio/tools/emulator/bin/em-cli" detail -n W-6.5-circle-x86
✔ Executing: "/Users/pauliusguzas/tizen-studio/tools/emulator/bin/em-cli" detail -n W-7.0-circle-x86
✔ Executing: "/Users/pauliusguzas/tizen-studio/tools/emulator/bin/em-cli" detail -n M-7.0-x86
✔ Executing: "/Users/pauliusguzas/tizen-studio/tools/emulator/bin/em-cli" detail -n M-6.5-x86
✔ Executing: "/Users/pauliusguzas/tizen-studio/tools/emulator/bin/em-cli" detail -n T-8.0-x86
? What emulator would you like to launch?
❯ T-8.0-x86_64
T-samsung-7.0-x86
T-8.0-x86
pauliusguzas@MBP-de-Flexn template-starter % npx rnv target launch -p tizen -t 1
92.168.1.204
┌─────────────────────────────────────────────────────────────────┐
│ ██████╗ ███████╗███╗ ██╗ █████╗ ████████╗██╗██╗ ██╗███████╗ │
│ ██╔══██╗██╔════╝████╗ ██║██╔══██╗╚══██╔══╝██║██║ ██║██╔════╝ │
│ ██████╔╝█████╗ ██╔██╗ ██║███████║ ██║ ██║██║ ██║█████╗ │
│ ██╔══██╗██╔══╝ ██║╚██╗██║██╔══██║ ██║ ██║╚██╗ ██╔╝██╔══╝ │
│ ██║ ██║███████╗██║ ╚████║██║ ██║ ██║ ██║ ╚████╔╝ ███████╗ │
│ ╚═╝ ╚═╝╚══════╝╚═╝ ╚═══╝╚═╝ ╚═╝ ╚═╝ ╚═╝ ╚═══╝ ╚══════╝ │
│ 🚀 v:1.2.0-rc.1 | renative.org | 9/18/2024, 5:28:26 PM │
│ $ rnv target launch -p tizen -t 192.168.1.204 │
└─────────────────────────────────────────────────────────────────┘
info: Current engine: @rnv/engine-rn-web (../engine-rn-web)
task: ○ target launch ↺1
task: ○ workspace configure ↺1
task: ✔ workspace configure
✖ FAILED: /Users/pauliusguzas/tizen-studio/tools/emulator/bin/em-cli launch --name 192.168.1.204
error: ⨯ ○ target launch: The VM "192.168.1.204" does not exist.
✔ Executing: "/Users/pauliusguzas/tizen-studio/tools/emulator/bin/em-cli" list-vm
✔ Executing: "/Users/pauliusguzas/tizen-studio/tools/sdb" devices
✔ Executing: "/Users/pauliusguzas/tizen-studio/tools/emulator/bin/em-cli" detail -n T-8.0-x86_64
✔ Executing: "/Users/pauliusguzas/tizen-studio/tools/emulator/bin/em-cli" detail -n T-samsung-7.0-x86
✔ Executing: "/Users/pauliusguzas/tizen-studio/tools/emulator/bin/em-cli" detail -n W-6.5-circle-x86
✔ Executing: "/Users/pauliusguzas/tizen-studio/tools/emulator/bin/em-cli" detail -n W-7.0-circle-x86
✔ Executing: "/Users/pauliusguzas/tizen-studio/tools/emulator/bin/em-cli" detail -n M-7.0-x86
✔ Executing: "/Users/pauliusguzas/tizen-studio/tools/emulator/bin/em-cli" detail -n M-6.5-x86
✔ Executing: "/Users/pauliusguzas/tizen-studio/tools/emulator/bin/em-cli" detail -n T-8.0-x86
? What emulator would you like to launch? (Use arrow keys)
❯ T-8.0-x86_64
T-samsung-7.0-x86
T-8.0-x86
192.168.1.204:26101
Description
Running
npx rnv run -p tizen
, now you can select from real connected devices.Running
npx rnv target list -p tizen
displays the real device IP only(no unnecessary, default info)Related issues
Npm releases
n/a