-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve regex overrides #1694
improve regex overrides #1694
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding marker comments like this:
import * as NativeComponentRegistry from '../../NativeComponent/NativeComponentRegistry';
import {ConditionallyIgnoredEventHandlers} from '../../NativeComponent/ViewConfigIgnore';
import Platform from '../../Utilities/Platform';/*RNV*/
import NativeModules from '../../BatchedBridge/NativeModules';/*RNV*/
would break overrides in files that don't support /**/
comments, like .podspec
or .properties
, as well as overrides in multiline strings or macros.
But in most use cases it would be fine, so just restricting it to languages that support /**/
comments might be enough, but it would make overrides work inconsistently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The resetOverrides
hook won't automatically run in users' projects. What exactly is it's purpose? What's the difference between it and taskPatchReset
?
It seems like overrides are also applied to subdependencies now:
"@react-native-community/cli": {},
"react-native/node_modules/@react-native-community/cli": {},
"react-native-tvos/node_modules/@react-native-community/cli": {},
but weren't before (in b16b40c):
"@react-native-community/cli": {},
@RicardasN had an issue with overriding subdependencies a little while ago. Is this an intentional change for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just merge e2e file changes from main
Description
npx rnv patch reset
=> revert applied overridesRelated issues
Npm releases
n/a
Testing
yarn bootstrap-clean
.rnv/overrides/applied_overrides.json
and be applied to node_modules.npx rnv patch reset
=> reverts applied overrides + deletes .rnv/overrides folder