Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a new platform to an existing project #1656

Merged
merged 6 commits into from
Aug 27, 2024
Merged

Conversation

ElenaDiachenko
Copy link
Contributor

Description

  • added the ability to add a new supported platform after project creation

Related issues

Npm releases

n/a

@ElenaDiachenko ElenaDiachenko self-assigned this Aug 20, 2024
@ElenaDiachenko ElenaDiachenko added this to the 1.1 milestone Aug 20, 2024
Copy link
Contributor

@Marius456 Marius456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Androidtv and tvos stuck in loading:
Screenshot 2024-08-21 at 18 47 40

Also it still ask to configure after platform configured:

  1. npx rnv run -p selected_platform
  2. You are trying to run platform selected_platform which is not configured. Do you want to configure it now? Yes
  3. works
  4. npx rnv run -p selected_platform
  5. You are trying to run platform selected_platform which is not configured. Do you want to configure it now?

@Marius456 Marius456 added the e2e label Aug 26, 2024
@Marius456 Marius456 modified the milestones: 1.1, 1.2 Aug 26, 2024
@pauliusguzas
Copy link
Collaborator

pauliusguzas commented Aug 26, 2024

I just tried running ios app-harness and it took 25 minutes, so maybe this PR introduces something which makes it run that long
│ Executed Time: 0h:25m:3s:135ms │
That is the reason e2e always fails as the timeout is set to 9 minutes

@pauliusguzas pauliusguzas self-requested a review August 27, 2024 09:32
@pauliusguzas pauliusguzas added e2e and removed e2e labels Aug 27, 2024
@pauliusguzas pauliusguzas merged commit b24a097 into main Aug 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants