CLI improvements

[locksten]

Description

• Allows unknown cli options for integrations, since they're not known when commander is being set up.
• Adds some TODO comments for other cli issues.
• update cli logging
• allow integrations to have single command tasks
• fix relative path printouts

How to test integration:

cd packages/app-harness
rnv starter hello -p ios --my-opt=hello

# prints: Hello from Integration Starter!
# --my-opt: "hello"

cd packages/app-harness
rnv starter-single-command -p ios --my-opt=hello

# prints: Hello from Integration Starter!
# --my-opt: "hello"

TODO NOTES:

– integrations can't use options that rnv uses, like "--version", because rnv just prints its version and exits. => this is standard behavior of most CLIs so it's more about conventions
– when using executeAsync(), spaces must be manually escaped.

Related issues

n/a

Npm releases

n/a

[GabrieleKaceviciute]

@pavjacko is it expected?

1. Print --my-opt: "undefined" in this way ->

➜  app-harness git:(feat/cli-updates) rnv

┌─────────────────────────────────────────────────────────────────┐
│ ██████╗ ███████╗███╗   ██╗ █████╗ ████████╗██╗██╗   ██╗███████╗ │
│ ██╔══██╗██╔════╝████╗  ██║██╔══██╗╚══██╔══╝██║██║   ██║██╔════╝ │
│ ██████╔╝█████╗  ██╔██╗ ██║███████║   ██║   ██║██║   ██║█████╗   │
│ ██╔══██╗██╔══╝  ██║╚██╗██║██╔══██║   ██║   ██║╚██╗ ██╔╝██╔══╝   │
│ ██║  ██║███████╗██║ ╚████║██║  ██║   ██║   ██║ ╚████╔╝ ███████╗ │
│ ╚═╝  ╚═╝╚══════╝╚═╝  ╚═══╝╚═╝  ╚═╝   ╚═╝   ╚═╝  ╚═══╝  ╚══════╝ │
│ 🚀 v:1.0.0-rc.12 | renative.org | 3/7/2024, 11:37:41 AM         │
│ $ rnv                                                           │
└─────────────────────────────────────────────────────────────────┘
? Pick a command starter-single-command (Prints hello message)
info: Running custom task starter-single-command
info: Current Engine: engine-core path: ../engine-core/lib
task: ○ starter-single-command [1]
info: ✔ Hello from Integration Starter single command!
--my-opt: "undefined"
task: ✔ starter-single-command [1]
┌─────────────────────────────────────────────────────────────────┐
│ ✔ SUMMARY | 3/7/2024, 11:37:47 AM | [email protected]             │
│ $ rnv                                                           │
├─────────────────────────────────────────────────────────────────┤
│ Project Name ($package.name): @rnv/app-harness                  │
│ Project Version ($package.version): 1.0.0-rc.12                 │
│ Workspace ($.workspaceID): rnv                                  │
│ Engine: engine-core                                             │
│ Build Scheme (-s): debug                                        │
│ Env Info: darwin | arm64 | node v18.19.0                        │
│ Executed Time: 0h:0m:6s:71ms                                    │
│ info: ✔ Hello from Integration Starter single command!
--my-opt: "undefined"
└─────────────────────────────────────────────────────────────────┘
➜  app-harness git:(feat/cli-updates)

2. If --my-opt value contains spaces -> printed only first word before space e.g. ->

➜  app-harness git:(feat/cli-updates) rnv starter hello --my-opt=bim bam

┌─────────────────────────────────────────────────────────────────┐
│ ██████╗ ███████╗███╗   ██╗ █████╗ ████████╗██╗██╗   ██╗███████╗ │
│ ██╔══██╗██╔════╝████╗  ██║██╔══██╗╚══██╔══╝██║██║   ██║██╔════╝ │
│ ██████╔╝█████╗  ██╔██╗ ██║███████║   ██║   ██║██║   ██║█████╗   │
│ ██╔══██╗██╔══╝  ██║╚██╗██║██╔══██║   ██║   ██║╚██╗ ██╔╝██╔══╝   │
│ ██║  ██║███████╗██║ ╚████║██║  ██║   ██║   ██║ ╚████╔╝ ███████╗ │
│ ╚═╝  ╚═╝╚══════╝╚═╝  ╚═══╝╚═╝  ╚═╝   ╚═╝   ╚═╝  ╚═══╝  ╚══════╝ │
│ 🚀 v:1.0.0-rc.12 | renative.org | 3/7/2024, 11:42:16 AM         │
│ $ rnv starter hello --my-opt=bim bam                            │
└─────────────────────────────────────────────────────────────────┘
info: Running custom task starter hello
info: Current Engine: engine-core path: ../engine-core/lib
task: ○ starter hello [1]
info: ✔ Hello from Integration Starter!
--my-opt: "bim"
task: ✔ starter hello [1]
┌─────────────────────────────────────────────────────────────────┐
│ ✔ SUMMARY | 3/7/2024, 11:42:16 AM | [email protected]             │
│ $ rnv starter hello --my-opt=bim bam                            │
├─────────────────────────────────────────────────────────────────┤
│ Project Name ($package.name): @rnv/app-harness                  │
│ Project Version ($package.version): 1.0.0-rc.12                 │
│ Workspace ($.workspaceID): rnv                                  │
│ Engine: engine-core                                             │
│ Build Scheme (-s): debug                                        │
│ Env Info: darwin | arm64 | node v18.19.0                        │
│ Executed Time: 0h:0m:0s:99ms                                    │
│ info: ✔ Hello from Integration Starter!
--my-opt: "bim"
└─────────────────────────────────────────────────────────────────┘
➜  app-harness git:(feat/cli-updates)

[pavjacko]

@pauliusguzas yes. 2nd issue is not an issue but generic terminal behavior. you need to wrap such input in quotations
--my-opt="bim bam"