-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ability to not distribute lumped elements #2132
base: pre/2.8
Are you sure you want to change the base?
Conversation
32f70e7
to
b779f78
Compare
Let's start with an RF team round of reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass through lumped_element. All look quite clear! Will take another look after break
Looks great, @dmarek-flex! I have a few questions, which I’ll address as I finish reviewing the code. |
bacfae4
to
d9c1af7
Compare
d9c1af7
to
2321ba3
Compare
…allow for restricting the network portion of the lumped element. PEC connections are used to connect to the bounds of the element. adding test coverage and fixing some corner cases fixed small possible bug when performing subdivision
2321ba3
to
a283bf7
Compare
Got a basic structure question for @daquinteroflex @tylerflex @yaugenst-flex . You will notice in this PR I added a For example, I plan on moving things like the path integrals from the microwave plugin to this folder in the future. The reason being is that I find that I will need to use these calculations when adding basic components like Voltage or Current monitors, so making those tools a part of a plugin doesn't really make sense to me. |
So I can't actually respond to this publicly so I've tagged the private issue to discuss this One approach is simply stick it in the plugins (for now) till we begin this migration effort. This is my preference actually @dmarek-flex if that sounds ok. We can do the migration effort together in another PR when the new structure is more defined if that sounds ok? What's your timeline and we can plan to do it for this since Charge is wrapping up? |
At high frequencies and mostly in the case of high impedances, distributing the lumped element over multiple grid cells breaks the assumption that the electric field is uniform within the lumped element. We now offer the ability to restrict the network portion of the lumped element to one grid cell and use automatically created PEC connections to connect the network portion of the lumped element to the bounds of the lumped element. We also have the ability restrict the network portion along the voltage axis but distribute the element laterally.
These PEC connections introduce parasitic inductances and capacitances that depend on the discretization used and which effectively modify the simulated network. In some cases, it will be possible to account for these, so we offer estimates for the values of these inductances and capacitances.
Example usage has been added to the associated notebook tutorial.