-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
call metadata api after uploading file #2114
Conversation
Thanks @magiWei It seems that some tests are failing because they are actually trying to connect to the server to estimate the cost? We need to mock that function in the tests. The other thing is, we also discussed adding a check estimate api call in |
About #2, it will check on API server side. |
Ah ok makes sense. For the tests I think you also need to add |
What is the most recent release version? Can we merge this feature into it? |
We are preparing a 2.8 pre-release right now. Normally we're not planning on making more 2.7 patches. |
@magiWei I also added a commit to remove the estimated cost message from We should also add a changelog item, I can do it when we get to a final state of this. |
It makes sense. I have no new commit. |
3f0115f
to
a7d0454
Compare
a7d0454
to
fa308fb
Compare
No description provided.