more autograd fixes for 2.7.8 #2082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tylerflex
commented
Nov 20, 2024
tylerflex
commented
- single cell approximation for CustomMedium was giving inaccurate gradients. Revert to old approach that sums over single cell dims at expense of more data.
- cherry pick this commit from 2.8 that fixes run_async for local gradients. d12ace8
yaugenst-flex
approved these changes
Nov 20, 2024
tylerflex
force-pushed
the
tyler/autograd_/fixes_2_7_8
branch
from
8535150 to
e539308
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.