fix: remove autograd temporary simulation files #2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerflex
approved these changes
Oct 23, 2024
tylerflex
approved these changes
Oct 23, 2024
|
good idea to add some, done |
yaugenst-flex
force-pushed
the
yaugenst-flex/fix-tempfile
branch
from
9f6f5ae to
34c9bfc
Compare
yaugenst-flex
force-pushed
the
yaugenst-flex/fix-tempfile
branch
from
34c9bfc to
0f68973
Compare
yaugenst-flex
force-pushed
the
yaugenst-flex/fix-tempfile
branch
from
0f68973 to
2687193
Compare
|
@momchil-flex can we merge this? |
yaugenst-flex
added
2.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, autograd temp files are being created but not removed in
upload_sim_fields_keysandget_vjp_traced_fields. This causes/tmpto eventually run out of space, especially when running longer optimizations.Right now, the file is being created, deleted, and then re-created with the name of the temp file in the
.to_file()anddownload_file()calls, respectively.Ideally we would be able to use a context manager here, but since we are overwriting the file handle, that approach doesn't work. We should probably be passing around file handles instead of names internally.