Convert several mode solver methods to staticmethods #2008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiliangjin2021
force-pushed
the
weiliang/mode_file
branch
from
08ec8e3 to
a95c1dc
Compare
weiliangjin2021
force-pushed
the
weiliang/mode_file
branch
from
a95c1dc to
e4a8a07
Compare
momchil-flex
approved these changes
Oct 15, 2024
weiliangjin2021
force-pushed
the
weiliang/mode_file
branch
from
e4a8a07 to
d605cf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to convert all methods involved in
_solve_single_freqto staticmethods, so that calling_solve_single_freqin a multiprocessing pool will not serialize unrelated data in mode solver. This is very helpful when the simulation field in mode solver is huge.