prioritize snapping points in AutoGrid #1831
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the snapping_points idea very useful, but also that the default value for the
min_step
was too restrictive. Here I propose some changes that give priority to the snapping points over the computed interval boundaries.dl_min
is defined, it becomes the size used as themin_step
. This is needed for Simulations with PECs since the calculatedmax_dl
is much too large to be useful.min_step
requirement though.