-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for EMESimulation in ModeSolver plugin #1802
Conversation
72cb023
to
fb5d740
Compare
14804c8
to
7135294
Compare
7135294
to
6b0da8e
Compare
9032511
to
9428854
Compare
9428854
to
50de43a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great addition. Thanks @caseyflex . I wonder if one uses the local mode solver to solve for the modes and dose smatrix_in_basis
for example with the mode solving result, would the accuracy be noticeably worse?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure to update the changelog to put this in the Added section of Unreleased instead of 2.7.1
cff45c1
to
a3a0399
Compare
I actually imagine it wouldn't matter so much. The mode profile should be similar, only the details and the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Does it really facilitate the ModeSimulation
refactor?
a3a0399
to
90d33de
Compare
We would like to pass a |
(even if this isn't the primary web api, it will help internally to support it, and it may be helpful for users as well) |
Previously, we could add a
ModeSolverMonitor
to anEMESimulation
, or we could convert the scene to aSimulation
to use theModeSolver
plugin. Now, we can directly pass anEMESimulation
to theModeSolver
plugin.The change was suggested by @tomflexcompute here: #1633
It will also facilitate the planned
ModeSimulation
classes.