fix box gradients < 3d #1801
Merged
fix box gradients < 3d #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerflex
force-pushed
the
tyler/autograd_/fix/box2d
branch
from
11769d5 to
3703cd1
Compare
tylerflex
requested review from
yaugenst-flex
and removed request for
momchil-flex
yaugenst-flex
approved these changes
Jul 4, 2024
tylerflex
force-pushed
the
tyler/autograd_/fix/box2d
branch
from
3703cd1 to
8ff13f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug that occurred in 2D autograd with
Box, wherexr.DataArray.integrategives 0 for any dimensions with 1 coordinate, making the whole gradient0. This simply ignores such dimensions in the integration.