fix smatrix component task_ids to/from file #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested with |
dmarek-flex
approved these changes
May 13, 2024
tylerflex
force-pushed
the
tyler/fix/smatrix_to_from_file
branch
3 times, most recently
from
d6423eb to
74349ba
Compare
tylerflex
force-pushed
the
tyler/fix/smatrix_to_from_file
branch
from
74349ba to
0d6d991
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No changelog needed I think because the PR that broke this hasn't been released.
I refactored Batch and Job recently #1630 . Before, the Job had task_id as a field that was created in a validator by uploading the task. Similarly, Batch.jobs was a field that was created in a validator by uploading all of the tasks. This meant that these fields were saved to file automatically. In the new refactor, these fields are just properties that are created when the Job/Batch is .upload() ed for the first time. So they aren’t saved to file natively, I needed to patch that into the .json() methods. Turned out I had done it so that a Batch worked properly when saved to file, but I needed to handle a component modeler too.