Improve voltage computation for lumped ports #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarek-flex
force-pushed
the
dmarek/improve_voltage_comp
branch
from
a26fbe7 to
2ae3986
Compare
tylerflex
approved these changes
Mar 7, 2024
tylerflex
reviewed
Mar 7, 2024
Yea I was about to add something to the changelog and saw the lumped ports stuff right above, so I decided not to change anything. |
dmarek-flex
force-pushed
the
dmarek/improve_voltage_comp
branch
from
2ae3986 to
662edd6
Compare
dmarek-flex
force-pushed
the
dmarek/improve_voltage_comp
branch
from
662edd6 to
03c473c
Compare
weiliangjin2021
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The E field is discontinuous at the port boundaries where conductors are present. In this picture the ground plane is at z=0 and the strip is at z=1000. Interpolation is inaccurate there, and even though only the end points are affected, it has a noticeable effect on accuracy.
Now, all field points outside the port bounds are ignored and linear extrapolation is used to estimate the E field on the exact port bounds.