Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ModeSolver.plot #1397

Closed
tylerflex opened this issue Jan 25, 2024 · 7 comments
Closed

add ModeSolver.plot #1397

tylerflex opened this issue Jan 25, 2024 · 7 comments
Assignees
@e-g-melo
Labels
good first issue

Comments

@tylerflex
Copy link
Collaborator

Would be nice to have a simple method to visualize the ModeSolver plane within the simulation, perhaps with a different color than a regular monitor or source.
@momchil-flex
Copy link
Collaborator

Also to visualize the plane cross-section (media/epsilon)

@momchil-flex
Copy link
Collaborator

@e-g-melo this is related to you working on a 2D plot of the mode solver that also shows the PML right?

@e-g-melo
Copy link
Collaborator

Hi @momchil-flex! Yes, it is.

@e-g-melo e-g-melo self-assigned this Jun 22, 2024
e-g-melo added a commit that referenced this issue Jul 1, 2024
@e-g-melo
Added: mode plane plotting functions (#1397).
e43534a
@e-g-melo e-g-melo mentioned this issue Jul 1, 2024
Merged
e-g-melo added a commit that referenced this issue Jul 5, 2024
@e-g-melo
Added: mode plane plotting functions (#1397).
1c6a438
momchil-flex pushed a commit that referenced this issue Jul 5, 2024
@e-g-melo @momchil-flex
Added: mode plane plotting functions (#1397).
d961248
@tylerflex
Copy link
Collaborator Author

@e-g-melo did your PR fix this issue? just checking in

@e-g-melo
Copy link
Collaborator

e-g-melo commented Dec 6, 2024

That PR allows you to plot the mode plane defined on ModeSolver. However, it won't include plotting the mode plane within the Simulation domain.

@e-g-melo
Copy link
Collaborator

e-g-melo commented Dec 6, 2024

Not sure if that is necessary, right?

@tylerflex
Copy link
Collaborator Author

I think it's ok and we can reopen if it's requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e-g-melo e-g-melo

Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@momchil-flex @tylerflex @e-g-melo