fix(lib): [format] empty string handling

Signed-off-by: Lexus Drumgold <[email protected]>
flex-development · Dec 16, 2022 · 5f0de54 · 5f0de54
1 parent 4263bf9
commit 5f0de54
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -23,7 +23,7 @@ const config = {
       }
     },
     {
-      files: ['./src/lib/resolve.ts'],
+      files: ['./src/lib/format.ts', './src/lib/resolve.ts'],
       rules: {
         '@typescript-eslint/prefer-nullish-coalescing': 0
       }

diff --git a/src/lib/__tests__/format.spec.ts b/src/lib/__tests__/format.spec.ts
@@ -27,7 +27,8 @@ describe('unit:lib/format', () => {
       [{ ext: '.png', name: 'x' }],
       [{ ext: '.html', name: 'index' }],
       [{ ext: '.html', name: 'index', root: '/' }],
-      [{ dir: 'some/dir', ext: '.html', name: 'index' }]
+      [{ dir: 'some/dir', ext: '.html', name: 'index' }],
+      [{ base: '', dir: 'lib', ext: '.mjs', name: 'index', root: '' }]
     ]
 
     // Act + Expect

diff --git a/src/lib/format.ts b/src/lib/format.ts
@@ -46,14 +46,14 @@ const format = (pathObject: FormatInputPathObject): string => {
    * @const {string} base
    */
   const base: string =
-    pathObject.base ?? `${pathObject.name ?? ''}${formatExt(pathObject.ext)}`
+    pathObject.base || `${pathObject.name ?? ''}${formatExt(pathObject.ext)}`
 
   /**
    * Directory name or full path.
    *
    * @const {string | undefined} dir
    */
-  const dir: string | undefined = pathObject.dir ?? pathObject.root
+  const dir: string | undefined = pathObject.dir || pathObject.root
 
   return !dir
     ? base