Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent premature draw calls and destroy encoding texture prior to recreation #208

Merged
merged 3 commits into from
Jan 9, 2025
Merged

fix: prevent premature draw calls and destroy encoding texture prior to recreation #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ace9b8
fix: prevent premature `draw()` calls
flekschas Jan 3, 2025
3687cd3
fix: destroy the encoding texture before recreating it
flekschas Jan 7, 2025
51dce09
chore: remove unused `catchError()`
flekschas Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
## 1.12.1

- Fix: destroy the encoding texture before recreating it
- Fix: reject `set()` calls if the instance was destroyed
- Fix: ensures unnecessary color and encoding texture updates are avoided
- Fix: color and encoding textures are destroyed upon calling `scatterplot.destroy()`
- Fix: prevent a minor memory leak in the newly added advanced exporter

## 1.12.0

- Feat: add support for adjusting the anti-aliasing via `scatterplot.set({ antiAliasing: 1 })`. ([#175](https://github.com/flekschas/regl-scatterplot/issues/175))
Expand Down
3 changes: 3 additions & 0 deletions src/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,3 +172,6 @@ export const DEFAULT_PIXEL_ALIGNED = false;

// Error messages
export const ERROR_POINTS_NOT_DRAWN = 'Points have not been drawn';
export const ERROR_INSTANCE_IS_DESTROYED = 'The instance was already destroyed';
export const ERROR_IS_DRAWING =
'Ignoring draw call as the previous draw call has not yet finished. To avoid this warning `await` the draw call.';
Loading
Loading