Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for linear and constant point scaling via a new property called pointScaleMode #195

Merged
merged 8 commits into from
Sep 28, 2024

Conversation

flekschas
Copy link
Owner

@flekschas flekschas commented Sep 28, 2024

This PR introduces a new property called pointScaleMode to add support for constant and linear point scaling.

Description

What was changed in this pull request?

We introduce a new property called pointScaleMode to allow the user to switch between three point scale modes:

  1. "asinh" transform (default)
  2. "linear" transform
  3. "constant" (a.k.a., no transform)

Why is it necessary?

This is a follow up PR to #194 (which was authored by @abast) to ultimately fix #169.

Checklist

  • Provided a concise title as a semantic commit message (e.g. "fix: correctly handle undefined properties")
  • CHANGELOG.md updated
  • Tests added or updated
  • Documentation in README.md added or updated
  • Example(s) added or updated
  • Screenshot, gif, or video attached for visual changes

…perty called `pointScaleMode` (#194)

* add pointScaleMode: proportional scales points proportional to zoom,  constant keeps point size constant, default keeps the current smart scaling strategy

* keep default mode to default; formatting

---------

Co-authored-by: basta <[email protected]>
@flekschas flekschas added the improvement Feature improvement or enhancement label Sep 28, 2024
@flekschas flekschas merged commit 11e3538 into master Sep 28, 2024
2 checks passed
@flekschas flekschas deleted the point-scale-mode branch September 28, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Feature improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constant point size when zooming
2 participants