Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drawing a single connecting line between points #141

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

flekschas
Copy link
Owner

This PR ensures that a single line connecting all points is drawn correctly.

Description

What was changed in this pull request?

Previously, when one attempted to draw a single point connection that connects all points, no line would be drawn. This is now working.

As part of this fix, I also fixed the draw() functions resolution to await the drawing of point connections (when showPointConnections is set to true). Previously, draw() would resolve as soon as the points were drawn but drawing lines typically takes longer. Hence, draw() resolved too early. With this PR, when showPointConnections is true, draw() will resolve after both, the points and the connections, have been drawn.

Why is it necessary?

Fixes #125

Checklist

  • Provided a concise title as a semantic commit message (e.g. "fix: correctly handle undefined properties")
  • CHANGELOG.md updated
  • Tests added or updated
  • Documentation in README.md added or updated
  • Example(s) added or updated
  • Screenshot, gif, or video attached for visual changes

@flekschas flekschas added the bug Something isn't working label Jun 23, 2023
@flekschas flekschas merged commit cb202fb into master Jun 23, 2023
@flekschas flekschas deleted the fix-drawing-single-connecting-line branch June 23, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connecting all points via a single line does not work
1 participant