Fix: prevent drawing points if all are filtered out

flekschas · Jan 7, 2025 · e6bf879 · e6bf879
1 parent 27ce203
commit e6bf879
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 1.12.1
+
+- Fix: prevent drawing points if all are filtered out ([#201](https://github.com/flekschas/regl-scatterplot/issues/201))
+
 ## 1.12.0
 
 - Feat: add support for adjusting the anti-aliasing via `scatterplot.set({ antiAliasing: 1 })`. ([#175](https://github.com/flekschas/regl-scatterplot/issues/175))

diff --git a/src/index.js b/src/index.js
@@ -2242,7 +2242,7 @@ const createScatterplot = (
     const filteredSelectedPoints = [];
 
     for (const pointIdx of pointIdxsArray) {
-      if (pointIdx < 0 || pointIdx >= numPoints) {
+      if (!Number.isFinite(pointIdx) || pointIdx < 0 || pointIdx >= numPoints) {
         // Skip invalid filtered points
         continue;
       }
@@ -4281,7 +4281,8 @@ const createScatterplot = (
         });
       }
 
-      if (isPointsDrawn) {
+      const numPoints = getNormalNumPoints();
+      if (isPointsDrawn && numPoints > 0) {
         drawPointBodies();
       }