fix: edge case where zoomToOrigin unsets the fixed camera (#203)

flekschas · Dec 11, 2024 · e2f0db8 · e2f0db8
1 parent 0162422
commit e2f0db8
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 1.11.3
+
+- Fix: catch another edge case where `zoomToOrigin` was unsetting the camera fixed state
+
 ## 1.11.2
 
 - Fix: handle camera fixing better by adding a dedicated prop called `cameraIsFixed`. Previously, the lasso end interaction would unset the camera fixing. ([#94](https://github.com/flekschas/regl-scatterplot/issues/94))

diff --git a/src/index.js b/src/index.js
@@ -2780,7 +2780,7 @@ const createScatterplot = (
           'transitionEnd',
           () => {
             resolve();
-            camera.config({ isFixed: false });
+            camera.config({ isFixed: cameraIsFixed });
           },
           1,
         );

diff --git a/tests/get-set.test.js b/tests/get-set.test.js
@@ -661,6 +661,10 @@ test('set({ cameraIsFixed })', async () => {
   scatterplot.set({ cameraIsFixed: true });
   expect(scatterplot.get('cameraIsFixed')).toBe(true);
 
+  // Adding this here to triple check that the programmatic zoom does not unset
+  // the camera fixed state
+  await scatterplot.zoomToOrigin();
+
   canvas.dispatchEvent(new WheelEvent('wheel', { deltaY: -100 }));
 
   await nextAnimationFrame();