Skip to content

Commit

Permalink
fix: type issues (#157)
Browse files Browse the repository at this point in the history
* Add `d3-scale` as dev dependencies

* Switch to ubuntu in the hope it fixes the sed issue

* Update CHANGELOG.md

* Split up build and test jobs
  • Loading branch information
flekschas authored Nov 3, 2023
1 parent 4e2c5d7 commit b02816a
Show file tree
Hide file tree
Showing 6 changed files with 243 additions and 238 deletions.
34 changes: 18 additions & 16 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,24 @@ on:

jobs:
build:
runs-on: macos-latest

strategy:
matrix:
node-version: [18.x]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
- run: npm ci
- run: npm run build --if-present
env:
CI: true

test:
runs-on: macos-latest
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- name: Install regl-scatterplot
run: npm ci
- name: Build regl-scatterplot
run: npm run build --if-present
- name: Test regl-scatterplot
run: npm test
node-version: 18
- run: npm ci
- run: npm test
timeout-minutes: 5
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:

jobs:
build:
runs-on: macos-latest
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
Expand All @@ -20,7 +20,7 @@ jobs:

publish-npm:
needs: build
runs-on: macos-latest
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
jobs:
build:
name: Create Release
runs-on: macos-latest
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 1.8.5

- Fix: add `d3-scale` types as a dev dependency [#153](https://github.com/flekschas/regl-scatterplot/issues/153)
- Fix: run CI workflows on Ubuntu to ensure the `sed` replacement call works properly [#153](https://github.com/flekschas/regl-scatterplot/issues/153)

## 1.8.4

- Fix a regression with the point opacity introduced in [v1.7.1](#1.7.1)
Expand Down
Loading

0 comments on commit b02816a

Please sign in to comment.