Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow disabling pan/zoom by fixing the camera #179

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

flekschas
Copy link
Owner

This PR adds support for disabling pan/zoom via scatter.camera(is_fixed=True)

Description

What was changed in this pull request?

You can control the camera's fixed state via

  • Scatter(camera_is_fixed=True)
  • scatter.camera(is_fixed=True)

Note that when the camera is fixed, manual pan and zoom is disabled. However, you can still pan and zoom programmatically via scatter.zoom()

Why is it necessary?

Fixes #176

Demo

Screen.Recording.2024-12-11.at.10.34.08.AM.mp4

Checklist

  • Provided a concise title as a semantic commit message (e.g. "fix: correctly handle undefined properties")
  • CHANGELOG.md updated
  • Tests added or updated
  • Documentation in API.md/README.md added or updated
  • Example(s) added or updated
  • Screenshot, gif, or video attached for visual changes

Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for calm-platypus-50e85d ready!

Name Link
🔨 Latest commit 4962fe1
🔍 Latest deploy log https://app.netlify.com/sites/calm-platypus-50e85d/deploys/6759c000eb38590008d28d55
😎 Deploy Preview https://deploy-preview-179--calm-platypus-50e85d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flekschas flekschas mentioned this pull request Dec 11, 2024
@flekschas flekschas force-pushed the flekschas/allow-fixing-camera branch from ad92937 to 4962fe1 Compare December 11, 2024 16:38
@flekschas flekschas merged commit 77111f7 into main Dec 12, 2024
10 checks passed
@flekschas flekschas deleted the flekschas/allow-fixing-camera branch December 12, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable pan / zoom
1 participant