Significant Performance Improvements in Exchange for slight loss of fidelity #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fleitz
added a commit
that referenced
this pull request
May 1, 2013
Significant Performance Improvements in Exchange for slight loss of fidelity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you look in instruments the original version was spending way too much time doing objc stuff - method dispatch/dealloc.
This patch switches to straight C code for the main loop. As part of that it approximates the colors rather than using the exact pixel values. This might even result in improved behavior as similar colors are bucketed together.
Maybe it should be a switch or something in case a user wants exact colors, but a 150x performance improvement seems worthwhile.