Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go 1.17.8 #4560

Merged
merged 4 commits into from
Mar 16, 2022
Merged

Go 1.17.8 #4560

merged 4 commits into from
Mar 16, 2022

Conversation

GuillaumeRoss
Copy link
Contributor

@zwass just to save you a bit of time on #4462 I went ahead and commited this. I am unsure why goreleaser-orbit only had 1.17 specified - if you feel like this is all good feel free to schedule this change when it makes sense, the vulnerability before 1.17.8 is not major at all for us.

@gitpod-io
Copy link

gitpod-io bot commented Mar 10, 2022

@vercel
Copy link

vercel bot commented Mar 10, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/fleet-dm/fleet/EB7EG7f6HQTkDG7Sz1QndLC9rBAt
✅ Preview: https://fleet-git-4462-update-go-fleet-dm.vercel.app

@GuillaumeRoss GuillaumeRoss temporarily deployed to Docker Hub March 10, 2022 23:55 Inactive
@GuillaumeRoss GuillaumeRoss marked this pull request as ready for review March 10, 2022 23:55
@GuillaumeRoss GuillaumeRoss requested a review from zwass as a code owner March 10, 2022 23:55
@GuillaumeRoss GuillaumeRoss linked an issue Mar 10, 2022 that may be closed by this pull request
Update go to 1.17.8 #4462
Closed
3 tasks
@lucasmrod
Copy link
Member

Let's also update go-version in the remaining ymls inside .github/workflows/, which run go tests/automation:

$ rg "go-version.*1.17." -l .github
.github/workflows/goreleaser-snapshot-fleet.yaml
.github/workflows/test-packaging.yml
.github/workflows/fleet-and-orbit.yml
.github/workflows/test-go.yaml
.github/workflows/test.yml
.github/workflows/goreleaser-fleet.yaml

(I wonder if there's a way to define this once for all workflows, no need to tackle that on this PR, just a thought.)

Enforcing go minimum 1.17.8
b0b5818 
Bumping minimum version in a few more files
@GuillaumeRoss GuillaumeRoss temporarily deployed to Docker Hub March 16, 2022 17:57 Inactive
@GuillaumeRoss
Copy link
Contributor Author

Updated as per @lucasmrod's comments!

@GuillaumeRoss GuillaumeRoss temporarily deployed to Docker Hub March 16, 2022 18:01 Inactive
@lucasmrod
Copy link
Member

lucasmrod commented Mar 16, 2022 •
edited
Loading

Thanks @GuillaumeRoss!

While we are at it, we just had our backend call a few minutes ago and were discussing upgrading straight to 1.18 (released yesterday). Could we try that on this PR? (alternatively we merge this one and I can create a new one for 1.18). Looks like the issue is fixed in 1.18 too (golang/go#51112).

@GuillaumeRoss
Copy link
Contributor Author

@lucasmrod Let's merge this one, then immediately create a new one. That way if we have any troubleshooting on 1.18 we will not hold back the fixing of a vulnerability (even though it's minor). OK with you?

@GuillaumeRoss GuillaumeRoss merged commit 8700fc6 into main Mar 16, 2022
@GuillaumeRoss GuillaumeRoss deleted the 4462-update-go branch March 16, 2022 18:57
martavis pushed a commit to martavis/fleet that referenced this pull request Mar 27, 2022
@martavis
Go 1.17.8 (fleetdm#4560)
4925ab1 
* Go 1.17.8

* Enforcing go minimum 1.17.8

Bumping minimum version in a few more files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasmrod lucasmrod lucasmrod approved these changes

@zwass zwass Awaiting requested review from zwass

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update go to 1.17.8
2 participants
@GuillaumeRoss @lucasmrod