Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow CSS properties: min-height, max-height #288

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Allow CSS properties: min-height, max-height #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/loofah/html5/safelist.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,9 @@ module SafeList
"line-height",
"list-style",
"list-style-type",
"max-height",
"max-width",
"min-height",
"min-width",
"order",
"overflow",
Expand Down
14 changes: 14 additions & 0 deletions test/html5/test_sanitizer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,13 +493,27 @@ def test_css_function_sanitization_strips_style_attributes_with_unsafe_functions
assert_match(%r/<span><\/span>/, sane.inner_html)
end

def test_css_max_height
html = '<div style="max-height: 100%;"></div>'
sane = Nokogiri::HTML(Loofah.scrub_html4_fragment(html, :escape).to_xml)

assert_match(/max-height/, sane.inner_html)
end

def test_css_max_width
html = '<div style="max-width: 100%;"></div>'
sane = Nokogiri::HTML(Loofah.scrub_html4_fragment(html, :escape).to_xml)

assert_match(/max-width/, sane.inner_html)
end

def test_css_min_height
html = '<div style="min-height: 100%;"></div>'
sane = Nokogiri::HTML(Loofah.scrub_html4_fragment(html, :escape).to_xml)

assert_match(/min-height/, sane.inner_html)
end

def test_css_min_width
html = '<div style="min-width: 100%;"></div>'
sane = Nokogiri::HTML(Loofah.scrub_html4_fragment(html, :escape).to_xml)
Expand Down