Add support for 'autoprune-unless' for extensions #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an existing flatpak feature that was never added to flatpak-builder, so it couldn't be used in app manifests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an existing flatpak feature that was never added to flatpak-builder, so it couldn't be used in app manifests.
I've simply duplicated the code for
enable-ifand changed the name. That was enough to getautoprune-unlessto pass through from the manifest to the app metadata.To help address flatpak/flatpak#2718, I looked into why
flatpak uninstall --unusedremoves 64bit nvidia drivers, but not 32bit. I discovered that theorg.freedesktop.Platform.GLextension point was defined withautoprune-unless=active-gl-driver, butorg.freedesktop.Platform.GL32was not, and that the latter is defined in each app that requires it, rather than in the runtime.With this in place, as long as all apps that define the extension point use
autoprune-unless=active-gl-driver, the GL32 extension should be removed just like the GL extension. I've only tested on my non-nvidia system, but it does seem to work as expected.Steam is actually already using
autoprune-unlessin its manifest, but it's currently being ignored.