Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print a soft deprecation warning when app-id is used #574

Closed
wants to merge 1 commit into from

Conversation

bbhtt
Copy link
Contributor

@bbhtt bbhtt commented Dec 12, 2023

See 261575f

@TingPing
Copy link
Member

I don't want to be super verbose about it as it doesn't really matter.

Maybe in 1.5.x.

@bbhtt
Copy link
Contributor Author

bbhtt commented Dec 15, 2023

Yea sure.

@bbhtt
Copy link
Contributor Author

bbhtt commented Dec 31, 2023

I'm closing this, I don't think the warning is very useful since this is never going to be removed.

Adding it to the docs was enough.

@bbhtt bbhtt closed this Dec 31, 2023
@bbhtt bbhtt deleted the app-id-warning branch December 31, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants