Set a download speed timeout in the curl session #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, so context for freedesktop-sdk is we have CI timeout around 24 hours since runtimes may take very long time to build, especially with qemu-binfmt. But we have a test at the end of pipeline that runs flatpak-builder which we want to fail reasonably fast. Occasionally mirror sources seem to hang resulting in entire pipeline hanging. |
TingPing
reviewed
Oct 16, 2023
This will abort the download if it’s slower than 10KB/sec for 60 seconds with CURLE_OPERATION_TIMEDOUT The limits are copied from flatpak/flatpak@d6b10c2 This seems it could be useful in CI which may want to proactively kill a pipeline if a download timeouts
bbhtt
force-pushed
the
curl-download-timeout
branch
from
bac7adc to
1660e9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will abort the download if it’s slower than 10KB/sec for 60 seconds with CURLE_OPERATION_TIMEDOUT
The limits are copied from flatpak/flatpak@d6b10c2
This seems it could be useful in CI which may want to proactively kill a pipeline if a download timeouts
I have no idea how to test this, but hopefully it works.
@nanonyme wanted this for Freedesktop SDK CI