WIP : Birdman dependency #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortonjt
commented
May 25, 2021
| params=["mu", "sigma", "disp", "batch", "reference"], | ||
| dims={ | ||
| "beta": ["covariate", "feature"], | ||
| "phi": ["feature"], |
There was a problem hiding this comment.
what the crap is going on here??
mortonjt
commented
May 25, 2021
| self.specify_model( | ||
| params=["mu", "sigma", "disp", "batch", "reference"], | ||
| dims={ | ||
| "beta": ["covariate", "feature"], |
There was a problem hiding this comment.
and here, this doesn't make sense ...
|
Basic tests are passing, so we'll merge. But note that we'll need to test slurm and add CI next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still work in progress, but this should be able to incorporate the birdman dependency after this pull request is merged : https://github.com/gibsramen/BIRDMAn/pull/44
Things that remain
estimatecommand to use Birdman