New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore nmodes input for type 3 on GPU #580

Merged

DiamonDinoia merged 1 commit into flatironinstitute:master from janden:cu_type3_no_modes

Oct 18, 2024

Collaborator

janden commented Oct 17, 2024 •

edited

Loading

Since we don't use this, no need to check if it's valid. This lets us call makeplan with nmodes set to NULL.


          cuda: ignore nmodes input for type 3

Since we don't use this, no need to check if it's valid.

janden requested a review from DiamonDinoia

October 17, 2024 20:44

DiamonDinoia approved these changes

View reviewed changes

DiamonDinoia marked this pull request as ready for review

October 18, 2024 11:52

DiamonDinoia merged commit bc4ddf9 into flatironinstitute:master

167 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet