[BugFix] Robustize cuFINUFFT Python guru interface. #426
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the docs:
finufft.Plan(n_modes_or_dim)
accepts(int, tuple[int])
cufinufft.Plan(n_modes)
accepts(int, tuple[int])
In practice
n_modes_or_dim
is transformed internally to a NumPy array, hence providing any iterable tofinufft.Plan()
works.However
n_modes
incufinufft.Plan()
is more restrictive: it works withtuple[int]
, fails planning iflist[int]
, and wrongfully passes planning ifndarray[int]
, but then seg-faults atexecute()
.The examples below showcase the problem:
This PR increases the robustness of
cufinufft.Plan()
to match the flexibility of the CPU interface.