-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pipewire permissions #315
Conversation
Started test build 172578 |
@@ -15,6 +15,7 @@ | |||
"--device=all", | |||
"--filesystem=host", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related, do you think we should split up the host
permission here? I'm open to any permissions to make it align with other flatpak standards.
Yes, now we have the package compiled with the library and, as a result,
|
Build 172578 successful
|
@zephyroths could you, please, test if this build solves the issue on your PC? UPD: I can reproduce the issue on my VM with fedora 40. This PR solves it. |
it works. but when I played some games using pipewire another issue appears, the audio seems to be speed up. It didn't happen with different audio drivers. |
Thank you! Indeed, the implementation of the driver still needs to be improved. The speed up issue you've noticed likely affects all build types, not just flatpak. Among the ones I've noticed are workarounds by changing additional options:
|
Just a suggestion: I think the I've seen many other manifests with this option, and it seems to work. |
Good to merge, then? |
Yup |
Should fix #314