Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update flatpak-builder to 1.4.1 #196

Merged
merged 7 commits into from
Feb 15, 2024
Merged

Update flatpak-builder to 1.4.1 #196

merged 7 commits into from
Feb 15, 2024

Conversation

hfiguiere
Copy link
Contributor

@hfiguiere hfiguiere commented Dec 3, 2023 •
edited
Loading

This bring the rename mime stuff.

aka flatpak/flatpak-builder#1

This also should close #187

@flathubbot
Copy link
Contributor

Started test build 85169

@flathubbot
Copy link
Contributor

Build 85169 failed

@hfiguiere
Copy link
Contributor Author

I'll fix the patches.

@hfiguiere
Copy link
Contributor Author

it's the patches to run appstream-glib on the host, but after 1.3.3 there is a big patch to use appstream-cli.

@nanonyme
Copy link
Collaborator

nanonyme commented Dec 3, 2023

Iirc it's not actually host host but inside the app instead of inside the build sandbox. That is, it uses appstream-glib build as part of org.flatpak.Builder.

@hfiguiere hfiguiere force-pushed the hfiguiere-patch-1.3.5 branch from 600b296 to b526be3 Compare December 27, 2023 16:27
@flathubbot
Copy link
Contributor

Started test build 90077

@hfiguiere hfiguiere changed the title Update flatpak-builder to 1.3.5 Update flatpak-builder to 1.4.0 Dec 27, 2023
@hfiguiere
Copy link
Contributor Author

1.4.0 so it's updated to that. I removed the patch.

@flathubbot
Copy link
Contributor

Build 90077 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/72758/org.flatpak.Builder.flatpakref

@hfiguiere hfiguiere mentioned this pull request Dec 27, 2023
Closed
@hfiguiere hfiguiere force-pushed the hfiguiere-patch-1.3.5 branch from b526be3 to 43e0432 Compare December 27, 2023 22:43
@hfiguiere
Copy link
Contributor Author

This should fix the screenshot bug

@hfiguiere
Copy link
Contributor Author

This should also fix #187

@flathubbot
Copy link
Contributor

Started test build 90162

@flathubbot
Copy link
Contributor

Build 90162 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/72842/org.flatpak.Builder.flatpakref

@hfiguiere
Copy link
Contributor Author

hfiguiere commented Dec 27, 2023 •
edited
Loading

works locally. not sure why the smoke test fail

nevermind I can reproduce

@hfiguiere hfiguiere force-pushed the hfiguiere-patch-1.3.5 branch 2 times, most recently from 9b87c0a to 5b4eac6 Compare December 28, 2023 01:05
@flathubbot
Copy link
Contributor

Started test build 90173

@hfiguiere
Copy link
Contributor Author

Now we need to qualify it on the backend.

@flathubbot
Copy link
Contributor

Build 90173 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/72854/org.flatpak.Builder.flatpakref

@hfiguiere hfiguiere mentioned this pull request Dec 28, 2023
Draft
@hfiguiere hfiguiere force-pushed the hfiguiere-patch-1.3.5 branch from 5b4eac6 to d5498bb Compare December 28, 2023 22:29
@flathubbot
Copy link
Contributor

Started test build 90313

@flathubbot
Copy link
Contributor

Build 90313 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/72996/org.flatpak.Builder.flatpakref

@hfiguiere hfiguiere force-pushed the hfiguiere-patch-1.3.5 branch from d5498bb to 09cb91e Compare January 5, 2024 15:47
@flathubbot
Copy link
Contributor

Started test build 91721

@flathubbot
Copy link
Contributor

Build 98631 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/81412/org.flatpak.Builder.flatpakref

@hfiguiere @barthalion
Update flatpak-builder to 1.4.0
6c3161b 
This bring the rename mime stuff.
Remove obsolete patch
This uses appstreamcli

Signed-off-by: Hubert Figuière <[email protected]>
@hfiguiere @barthalion
Remove libsoup-2.4
c2ba327 
Signed-off-by: Hubert Figuière <[email protected]>
@hfiguiere @barthalion
Remove appstream-glib
f18ef42 
Signed-off-by: Hubert Figuière <[email protected]>
@hfiguiere @barthalion
flatpak-builder: tell appstream compose to canonicalize URL
74cf533 
Signed-off-by: Hubert Figuière <[email protected]>
@hfiguiere @barthalion
Update to 1.4.1
5721c1d 
Signed-off-by: Hubert Figuière <[email protected]>
@barthalion barthalion force-pushed the hfiguiere-patch-1.3.5 branch from 6755eb8 to 7dcc3c0 Compare February 14, 2024 08:08
@flathubbot
Copy link
Contributor

Started test build 99666

@flathubbot
Copy link
Contributor

Started test build 99668

@flathubbot
Copy link
Contributor

Build 99666 failed

@flathubbot
Copy link
Contributor

Build 99668 failed

@flathubbot
Copy link
Contributor

Started test build 99671

@flathubbot
Copy link
Contributor

Build 99671 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/82463/org.flatpak.Builder.flatpakref

@barthalion barthalion force-pushed the hfiguiere-patch-1.3.5 branch from ac43751 to 6b21092 Compare February 14, 2024 10:32
@flathubbot
Copy link
Contributor

Started test build 99694

@flathubbot
Copy link
Contributor

Build 99694 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/82485/org.flatpak.Builder.flatpakref

@barthalion barthalion force-pushed the hfiguiere-patch-1.3.5 branch from 6b21092 to 77c050a Compare February 14, 2024 11:04
@flathubbot
Copy link
Contributor

Started test build 99695

@barthalion barthalion force-pushed the hfiguiere-patch-1.3.5 branch from 77c050a to faa8bee Compare February 14, 2024 11:09
@flathubbot
Copy link
Contributor

Started test build 99696

@flathubbot
Copy link
Contributor

Build 99695 was cancelled

@flathubbot
Copy link
Contributor

Build 99696 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/82489/org.flatpak.Builder.flatpakref

@barthalion barthalion force-pushed the hfiguiere-patch-1.3.5 branch from faa8bee to cdffe17 Compare February 15, 2024 08:25
@flathubbot
Copy link
Contributor

Started test build 99949

@flathubbot
Copy link
Contributor

Build 99949 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/82744/org.flatpak.Builder.flatpakref

@barthalion barthalion merged commit 5aaf845 into master Feb 15, 2024
2 checks passed
@barthalion barthalion deleted the hfiguiere-patch-1.3.5 branch February 15, 2024 08:51
@Zishan-Rahman Zishan-Rahman mentioned this pull request Feb 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barthalion barthalion Awaiting requested review from barthalion barthalion is a code owner

@nanonyme nanonyme Awaiting requested review from nanonyme

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Valid license expression not being accepted by appstream-util
4 participants
@hfiguiere @flathubbot @nanonyme @barthalion