-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use single extension point for extensions, policies and native messaging hosts? #49
Comments
I wouldn't mind to change the extension points to support all dirs or maybe come up with a new extension point for that, but we should avoid changing the existing ones on a backwards incompatible way as that would break existing users which expect the current structure. Fwiw, there is nothing blocking packages to ship multiple extension points (extension + policy) in the same underlying package (e.g. for unmanaged extensions, as we do on Endless OS) |
Do you know of any other real-world usage of the extension points except EndlessOS?
This is possible for unmanaged extensions, but not for native flatpaks. Maintainer has no means to make sure that interdependent extensions are installed simultaneously. |
Native messaging host needs a path to a binary, the directory is just for the json metadata around the connection I believe(?). Where should that be? Right now ubuntu kde just puts its binary - /usr/bin/plasma-browser-integration-host |
@hammerandtongs Binary can be stored in the flatpak extension bundle, alongside json metadata. Doing so for Plasma Browser Integration in particular, though, won't be easy due to dependency on Qt/KDE. Also some |
Not that I know of.
I think the best to do in this case would be to come up with a new extension point then - would be happy to review if someone comes up with a PR but won't have time to look at this atm I'm afraid. |
NP, this issue is more of a RFE than an actual issue. Just wanted to point out that current layout may potentially pose a problem for flatpak'ing Chromium extensions, if someone decides to do it.
It'll need a new mount point. Would Chromium be able to pick up extension/policy files from multiple directories? E.g. load policy from |
I don't see why not, even if the current code only supports one dir we can always change that.
Not sure tbh, I would have to try and see. |
The source assumes a single directory for these in several places, changing it wouldn't be impossible but would be moderately invasive (and also fun to rebase). That being said, I guess we could also merge some of this by hand in the wrapper script, IIRC the target of merge-dirs is a tmpfs.
I don't entirely understand this suggestion, is it to replace the current, multiple extension points for extensions & native messaging hosts with a single one? |
Well, yes, but not necessarily replace existing ones, just to have such an extension point that could contain everything. |
We can't have multiple extensions mounted on one path, since Flatpak mounts a clean tmpfs for each one. That being said, I guess we could introduce a single one, and use some symlink magic in the startup scripts to keep compat with the previous extension points. |
Are there any ideas on implementing this change? Currently extension points for NMH and policies are broken and cannot be used (#78). Looks like this change may help. |
It's fairly common that a vendor wants to ship several objects of these 3 kinds at once, which may be interdependent. For example, in Fedora the package
fedora-chromium-config
contains an extension and a policy. Things like KeePassXC and Plasma Browser Integration consist of an extension and a native messaging host.Currently, it's not possible to ship different kinds of such extensions in one bundle. Using single extension point with
merge-dirs
set tonative-messaging-hosts;extensions;policies/managed;policies/recommended
would solve this.The text was updated successfully, but these errors were encountered: